-
Notifications
You must be signed in to change notification settings - Fork 93
fix: enable jumbo transaction feature #4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e5c998 to
3913616
Compare
19d7bc1 to
a9f2339
Compare
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
…umbo TX Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
a9f2339 to
b377797
Compare
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
b377797 to
0ff4709
Compare
Signed-off-by: Logan Nguyen <[email protected]>
714882b to
f6a29e5
Compare
.../server/tests/acceptance/data/conformity/overwrites/eth_call/call-callenv-options-eip1559.io
Show resolved
Hide resolved
...rver/tests/acceptance/data/conformity/overwrites/eth_estimateGas/estimate-simple-transfer.io
Show resolved
Hide resolved
This reverts commit 0ff4709. Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
|
Note for reviewers: The StepSecurity failed because of [email protected] is too fresh 😅 . This will auto resolved on Oct 10th.
|
natanasow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4419 +/- ##
==========================================
+ Coverage 96.23% 96.25% +0.01%
==========================================
Files 121 121
Lines 19941 19941
Branches 1754 1754
==========================================
+ Hits 19191 19194 +3
Misses 728 728
+ Partials 22 19 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|

Description
This PR enables Jumbo Transaction support by upgrading
@hashgraph/hedera-localfrom2.32.5to2.39.0, which brings [email protected] and [email protected]. This major version jump introduces breaking changes that required extensive test updates and fixes to accommodate new network behaviors, including HIP-1084: Zero Cost EthereumTransaction on Success, HIP-1086: Jumbo EthereumTransaction and Mirror Node Modularized ServiceKey Changes:
@hashgraph/hedera-local2.32.5 → 2.39.0 ([email protected], [email protected])JUMBO_TX_ENABLED=falseflag from all test environmentsRelated issue(s)
Fixes #3769
Changes from original design
JUMBO_TX_ENABLED=falseflag from test environments as Jumbo Transaction is now enabled by defaulteth_callandeth_estimateGasto match new gas behaviorJUMBO_TX_ENABLEDfor specific tests incompatible with Jumbo transactions (via test override)Additional work needed (optional)
This PR will be opened for review once Mirror Node releases version 0.140.0 GA and
@hashgraph/hedera-localupgrades to that version.N/A
Checklist