Skip to content

Prevent proto package recompiling on every build #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+9 −6
Open

Prevent proto package recompiling on every build #941

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b97e411
Prevent proto package from recompiling on every build.
tr11 May 3, 2025
6f033d5
Make sure the sdk folder is checked
tr11 May 3, 2025
ce7aa5e
Merge branch 'main' into fix-proto-recompiling
gsstoykov May 21, 2025
5088387
Merge branch 'main' into fix-proto-recompiling
tr11 Jun 27, 2025
1884cee
Update proto build script for 0.35.0
tr11 Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions protobufs/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
// SPDX-License-Identifier: Apache-2.0

use std::env;
use std::fs::{
self,
create_dir_all,
read_dir,
};
use std::fs::{self, create_dir_all, read_dir};
use std::path::Path;

use anyhow::Ok;
Expand Down Expand Up @@ -150,11 +146,14 @@ fn main() -> anyhow::Result<()> {
"crate::services::ConsensusMessageChunkInfo",
)
.out_dir(&mirror_out_dir)
.emit_rerun_if_changed(false)
.compile_protos(
&["./mirror/consensus_service.proto", "./mirror/mirror_network_service.proto"],
&["./mirror/", out_path.to_str().unwrap()],
)?;

println!("cargo:rerun-if-changed={}", "./mirror");

remove_useless_comments(&mirror_out_dir.join("proto.rs"))?;

// sdk
Expand Down Expand Up @@ -232,11 +231,15 @@ fn main() -> anyhow::Result<()> {
.services_same("UtilPrngTransactionBody")
.services_same("VirtualAddress");

cfg.out_dir(&sdk_out_dir).compile_protos(
// disable emitting for the generated proto files
cfg.out_dir(&sdk_out_dir).emit_rerun_if_changed(false).compile_protos(
&["./sdk/transaction_list.proto"],
&["./sdk/", out_path.to_str().unwrap()],
)?;

// check if the "./sdk" folder has changed
println!("cargo:rerun-if-changed={}", "./sdk");

// see note wrt services.
remove_useless_comments(&sdk_out_dir.join("proto.rs"))?;

Expand Down
Loading