Skip to content

Conversation

tbrowder
Copy link

No description provided.

perl6-imenu.el Outdated

;; Add imenu support for perl6-mode. Note that imenu-generic-expression
;; is buffer-local, so we don't need a local-variable for it.
(setq imenu-generic-expression perl6-imenu-generic-expression
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expression should be moved into perl6-mode. This expression makes no sense because both imenu-generic-expression and imenu-case-fold-search are buffer local variable.

@tbrowder
Copy link
Author

I've incorporated your comments as best I can, and it still works! However, I couldn't find a way to remove this line:

(add-hook 'perl6-mode-hook 'imenu-add-menubar-index)

and still have a working imenu mode completely, but at least it is now in the main file with the other add-hook lines.

Please comment on anything else you think needs changing.

@tbrowder
Copy link
Author

Added new features including index of classes, proto as type of sub, generalizing and documenting regexes better, a short test file to help develop regexes for various index items.

@JJ
Copy link

JJ commented Dec 26, 2016

Would it be worth the while to merge these in an independent repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants