Skip to content

Fixed rendering of MsgSecurityOption for OPC UA #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 25, 2025
Merged

Fixed rendering of MsgSecurityOption for OPC UA #1296

merged 5 commits into from
Nov 25, 2025

Conversation

@codepitbull
Copy link
Contributor

@codepitbull codepitbull commented Nov 19, 2025 •
edited
Loading

Motivation

Resolves #38115

Changes

  • MsgSecurity was rendered incorrectly because of an annotation vs enum-name clash.
  • Selecting x509/Basic Auth and then persisting lead to a situation where the UI would display an error because the non-selected part was sent as a null, breaking rendering.

@cla-bot cla-bot bot added the cla-signed label Nov 19, 2025
@codepitbull codepitbull requested a review from a team November 19, 2025 15:49
caoccao
caoccao approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@caoccao caoccao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marregui
marregui approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@marregui marregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codepitbull codepitbull merged commit a62617d into master Nov 25, 2025
7 of 8 checks passed
@codepitbull codepitbull deleted the fix/38115-rendering-msgsecurity branch November 25, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marregui marregui marregui approved these changes

@caoccao caoccao caoccao approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codepitbull @marregui @caoccao