Skip to content

Conversation

wilx
Copy link
Contributor

@wilx wilx commented Apr 12, 2025

Description

There appears to be a defect in ImmutableIntList#of(int, int, int, int...). It does not actually store 2nd and 3rd item correctly.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created.
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

Copy link

cla-bot bot commented Apr 12, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@wilx wilx force-pushed the master-immutable-list-of-three branch from 81312a7 to 5197132 Compare April 12, 2025 08:56
Copy link

cla-bot bot commented Apr 12, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@wilx
Copy link
Contributor Author

wilx commented Apr 15, 2025

FYI, I did sign the CLA.

@wilx
Copy link
Contributor Author

wilx commented Jun 10, 2025

Ping. Is it really that hard to get this simple fix in?

Copy link
Contributor

@MicWalter MicWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Hopefully my approval is accepted

@MicWalter MicWalter force-pushed the master-immutable-list-of-three branch from 5197132 to 23c918d Compare August 20, 2025 08:49
Copy link

cla-bot bot commented Aug 20, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@wilx
Copy link
Contributor Author

wilx commented Aug 20, 2025

I re-signed the CLA. It should be OK now.

@SgtSilvio
Copy link
Member

@cla-bot check

Copy link

cla-bot bot commented Aug 28, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

Copy link

cla-bot bot commented Aug 28, 2025

The cla-bot has been summoned, and re-checked this pull request!

@MicWalter
Copy link
Contributor

Kinda embarrassed to ask this of you, but can you please sign one last time. We improved the pipeline so that now the process doesn't depend on one person (so I can add you to the list).

@wilx
Copy link
Contributor Author

wilx commented Aug 28, 2025

Kinda embarrassed to ask this of you, but can you please sign one last time. We improved the pipeline so that now the process doesn't depend on one person (so I can add you to the list).

Done.

@MicWalter
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 28, 2025
Copy link

cla-bot bot commented Aug 28, 2025

The cla-bot has been summoned, and re-checked this pull request!

@MicWalter
Copy link
Contributor

@cla-bot check

@SgtSilvio SgtSilvio merged commit c93903c into hivemq:master Aug 29, 2025
1 check passed
@SgtSilvio
Copy link
Member

Thanks @wilx for your contribution. Sorry for not getting to merge this for a long time.
For anyone concerned: the specific function that was fixed is actually not used so did not cause bugs when just using the MQTT client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants