-
Notifications
You must be signed in to change notification settings - Fork 172
ImmutableIntList of four does not store 2nd and 3rd element correctly. #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
81312a7
to
5197132
Compare
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
FYI, I did sign the CLA. |
Ping. Is it really that hard to get this simple fix in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Hopefully my approval is accepted
5197132
to
23c918d
Compare
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
I re-signed the CLA. It should be OK now. |
@cla-bot check |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
The cla-bot has been summoned, and re-checked this pull request! |
Kinda embarrassed to ask this of you, but can you please sign one last time. We improved the pipeline so that now the process doesn't depend on one person (so I can add you to the list). |
Done. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@cla-bot check |
Thanks @wilx for your contribution. Sorry for not getting to merge this for a long time. |
Description
There appears to be a defect in
ImmutableIntList#of(int, int, int, int...)
. It does not actually store 2nd and 3rd item correctly.Related Issue
Type of Change
Checklist