Skip to content

[HGNN-7853] handle IllegalArgumentException during closeDialog #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[HGNN-7853] handle IllegalArgumentException during closeDialog #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/android/InAppBrowser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,8 +556,12 @@ public void run() {
childView.setWebViewClient(new WebViewClient() {
// NB: wait for about:blank before dismissing
public void onPageFinished(WebView view, String url) {
if (dialog != null && !cordova.getActivity().isFinishing()) {
dialog.dismiss();
if (dialog != null && dialog.isShowing() && !cordova.getActivity().isFinishing()) {
try {
dialog.dismiss();
} catch(IllegalArgumentException e) {
LOG.e(LOG_TAG, "Caught exception when trying to close IAB dialog: " + e);
}
dialog = null;
}
}
Expand Down