Skip to content

Do not use an instance variable in rack middleware #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not use an instance variable in rack middleware #109

wants to merge 1 commit into from
+21 −20

Conversation

@pbstriker38
Copy link

  • This was not thread safe

fixes: #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rafaelfranca rafaelfranca rafaelfranca approved these changes

@jhass jhass jhass approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Middleware is not thread safe

3 participants

@pbstriker38 @rafaelfranca @jhass