Skip to content

Conversation

@fiag
Copy link

@fiag fiag commented Mar 2, 2021

fix #781, add tcp_nodelay option in the TcpListener struct.
enable tcp_nodelay by default.

@jbr
Copy link
Member

jbr commented Mar 2, 2021

Is there any reason we wouldn't want to enable this by default?

@Fishrock123
Copy link
Member

Isn't TCP_NODELAY unsuitable for some http applications? I'm uneasy about doing this by default.

@fiag
Copy link
Author

fiag commented Mar 5, 2021

Refer to the Nginx module settings. It's safe to enable when keep-alive.

The option is enabled when a connection is transitioned into the keep-alive state.

@fiag
Copy link
Author

fiag commented Mar 5, 2021

Seem that it is hard to check keepalive of TcpSteam right now. 🤔

@fiag
Copy link
Author

fiag commented May 14, 2021

#823 use listener instead

@fiag fiag closed this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enormous latency regression

3 participants