Skip to content

🌐 [i18n-KO] Translated chapter3/5.mdx to Korean #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chhaewxn
Copy link
Contributor

@chhaewxn chhaewxn commented Aug 3, 2025

What does this PR do?

Translated the chapter3/5.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of huggingface/transformers#20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?

@yijun-lee, @songi104, @chhaewxn, @AhnJoonSung, @jihyun-0611, @seopp, @pyapyapya

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

seopp

This comment was marked as outdated.

Copy link
Contributor

@seopp seopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼한 번역 정말 잘 봤습니다! 몇 가지 작은 코멘트 남겨요. ㅎㅎ 제안 드린 내용들은 필수는 아니니, 편하게 보시고 더 나은 방향으로 반영해주시면 좋을 것 같아요. 고생 많으셨습니다!

@chhaewxn chhaewxn marked this pull request as ready for review August 9, 2025 07:01
Copy link

@AhnJoonSung AhnJoonSung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, I'll merge once the feedback is addressed! 🤗

@chhaewxn
Copy link
Contributor Author

chhaewxn commented Aug 11, 2025

LGTM thanks, I'll merge once the feedback is addressed! 🤗

@stevhliu The feedback has been addressed! Please proceed with the merge🙇‍♀️ Thank you 🤗

@stevhliu
Copy link
Member

Awesome, I'll merge once a small issue is fixed with the doc-builder. No further action is needed on your part! :)

@stevhliu stevhliu merged commit 9124fc0 into huggingface:main Aug 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants