fix(cache_metrics): clamp negative total values before writing to DB #3204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2495
This PR ensures that
total
values stored in the cache metrics collection are never negative.Specifically:
collect_cache_metrics()
, we now clamp thetotal
tomax(total, 0)
before calling.upsert_one()
While the
total
originates fromget_responses_count_by_kind_status_and_error_code()
, this fix guarantees data consistency at the write layer.