feat(rows): exclude heavy binary columns from /rows response to avoid UI lag (#3052) #3209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_latents from /rows output feat(rows): exclude heavy binary columns like t5_prompt_embeds and vae_latents from /rows output This change introduces a safeguard against rendering performance issues in the Dataset Viewer by skipping certain heavy binary columns (e.g., ~5KB per row) that are not useful for display. Currently hardcoded to drop columns like "t5_prompt_embeds" and "vae_latents", which caused UI freezing in datasets like `frutiemax/themoviedb_posters`. This is handled right before response construction in the /rows endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3052
This PR improves the responsiveness of the Dataset Viewer by skipping binary-heavy columns (e.g.,
t5_prompt_embeds,vae_latents) from the/rowsendpoint payload.These columns typically contain thousands of bytes per row and are not meaningful in the UI. The change introduces a hardcoded exclusion list (
EXCLUDED_COLUMNS) and drops those columns from the finalpyarrow.Tablebefore response generation.Tested manually using datasets with large binary columns and confirmed a reduction in payload size and frontend lag.
Future improvements could include: