Guard against duplicate builder_kwargs/config_kwargs in load_dataset_… #7622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shohail-Ismail
force-pushed
the
fix-build-kwarg-conflict
branch
from
e740409 to
61de0c5
Compare
|
Hi folks, this PR fixes the duplicate-kwargs edge case and includes a unit test. Would love a review when you have a moment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…builder (#4910 )
What does this PR do?
Fixes edge case in
load_dataset_builderby raising aTypeErrorif the same key exists in bothbuilder_kwargsandconfig_kwargs.Implementation details
Added a guard clause in
load_dataset_builderto detect duplicate keys betweenbuilder_kwargsandconfig_kwargsWrote a unit test in
tests/test_load_duplicate_keys.pyto verify the exception is raised correctlyFixes
Closes #4910
Reviewers
@zach-huggingface
@SunMarc
Would appreciate your review if you have time - thanks!