Skip to content

feat(load): fallback to load_from_disk() when loading a saved dataset directory #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(load): fallback to load_from_disk() when loading a saved dataset directory #7653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/datasets/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
from .fingerprint import Hasher
from .info import DatasetInfo, DatasetInfosDict
from .iterable_dataset import IterableDataset
from .load_from_disk import load_from_disk
from .naming import camelcase_to_snakecase, snakecase_to_camelcase
from .packaged_modules import (
_EXTENSION_TO_MODULE,
Expand Down Expand Up @@ -1362,6 +1363,18 @@ def load_dataset(
>>> ds = load_dataset('imagefolder', data_dir='/path/to/images', split='train')
```
"""
# Fallback: auto-detect save_to_disk-style folders
if (
os.path.isdir(path)
and os.path.exists(os.path.join(path, "dataset_info.json")) # for Dataset
or os.path.exists(os.path.join(path, "dataset_dict.json")) # for DatasetDict
):
logger.warning(
"Detected a directory saved via `save_to_disk()`. Redirecting to `load_from_disk('%s')` for compatibility.",
path,
)
return load_from_disk(path)

if "trust_remote_code" in config_kwargs:
if config_kwargs.pop("trust_remote_code"):
logger.error(
Expand Down