Skip to content

Deprecate Flax support #12151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Deprecate Flax support #12151

wants to merge 13 commits into from

Conversation

sayakpaul
Copy link
Member

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul marked this pull request as ready for review August 15, 2025 03:55
@sayakpaul sayakpaul requested review from DN6 and yiyixuxu August 15, 2025 03:55
@sayakpaul sayakpaul changed the title [wip] Deprecate Flax support Deprecate Flax support Aug 15, 2025
@@ -151,6 +156,11 @@ class FlaxAttention(nn.Module):
dtype: jnp.dtype = jnp.float32

def setup(self):
logger.warning(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought of adding it to all the public Flax classes, can remove.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@sayakpaul
Copy link
Member Author

@DN6 should we consider removing JAX and Flax from setup.py as well?

@sayakpaul
Copy link
Member Author

Over to you, @yiyixuxu :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants