no_init_weights
in from_pretrained
should be optional
#12153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After
diffusers>=0.33
,no_init_weights
is force applied infrom_pretrained
to speed up loading large models. But if user add new parameters to pretrained models (like Adapters), new parameters will not be initialized and may have NaNs to crash the model.This PR:
no_init_weights
infrom_pretrained
optional.no_init_weights
andinit_weights
option tofrom_single_file
to align withfrom_pretrained
.Crash example:
Use example:
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.