Deprecate slicing and tiling methods from DiffusionPipeline
#12271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
DN6
reviewed
Sep 9, 2025
| @@ -1705,6 +1705,12 @@ def enable_vae_tiling(self): | |||
| compute decoding and encoding in several steps. This is useful for saving a large amount of memory and to allow | |||
| processing larger images. | |||
| """ | |||
| depr_message = "Calling `enable_vae_tiling()` on a `DiffusionPipeline` is deprecated and this method will be removed in a future version. Please use `pipe.vae.enable_tiling()`." | |||
There was a problem hiding this comment.
Perhaps use "Calling enable_vae_tiling() on a {cls.__name__} is deprecated`? So the specific pipeline name shows up in the message?
DN6
reviewed
Sep 9, 2025
DN6
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Calling
pipe.enable_vae_tiling()is same callingpipe.vae.enable_tiling(). Same applies for slicing, too.We can remove these methods to encourage users to be more explicit (in this case even the line of code doesn't change).
This PR starts a deprecation cycle for these methods.