-
Notifications
You must be signed in to change notification settings - Fork 6.4k
[unbloating] move pipeline utilities to pipeline_utils
#12356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Nice, i do know there is a do repeat yourself ethos and I'm not a massive fan of overly DRY code with confusing abstractions. But think in allot of cases lifting more of the common things out instead of the # Copied from makes allot more sense in readability. Especially as more and pipelines are sharing ideas from one another. |
Thanks @JoeGaffney! Yes, those will essentially be considered similar to how |
Looks good to me. cc: @yiyixuxu here too. |
@yiyixuxu a gentle ping when you get time. |
What does this PR do?
Move methods like
calculate_shift()
,retrieve_latents()
, andretrieve_timesteps()
topipeline_utils.py
to reduce a lot of LOC.Didn't make these changes to the files under
examples/community
.Note
I didn't start any deprecation for this because the respective scripts from which these methods are removed will anyway contain their imports.