[OpenVINO] Update InferRequestWrapper to collect samples taking into account state of stateful models #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
nikita-savelyevv
changed the title
AlexanderDokuchaev
pushed a commit
to openvinotoolkit/nncf
that referenced
this pull request
Dec 2, 2025
…ful OV models (#3714) ### Changes Added `nncf.definitions.NNCF_DATASET_RESET_STATE_KEY` constant to specify when to reset model state. This constant is used by OpenVINO backend to control resetting of internal model state between model inferences. This key can be added to a dataset sample input dictionary with either `True` or `False` value. With `True` value, the model state will be reset before inference on the corresponding sample, and with `False` the state will not be reset. For an example of usage please see huggingface/optimum-intel#1505. ### Reason for changes Without this logic static quantization quality of stateful Whisper models is poor because a state of a stateful model must be cleared with the same schedule as it is done during calibration input data collection. ### Related tickets 172705 ### Tests Added `tests/openvino/native/test_engine.py::test_stateful_model_inference_with_controlled_resetting`.
There was a problem hiding this comment.
Pull request overview
This PR enhances the InferRequestWrapper class to properly handle state management for stateful OpenVINO models during quantization calibration. The changes ensure that state reset operations are tracked and communicated to NNCF's calibration process, which is critical for accurate quantization of stateful models like Whisper.
Key changes:
- Added state tracking mechanism to detect and record when model state is reset
- Modified input collection to include state reset information for NNCF calibration (version 2.19+)
- Implemented
reset_state()method wrapper to track state reset calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nikita-savelyevv
added
the
openvino-nightly
nikita-savelyevv
force-pushed
the
ns/stateful-models-quantization
branch
from
76a11e5 to
03ce84c
Compare
nikita-savelyevv
requested review from
IlyasMoutawwakil,
echarlaix and
rkazants
echarlaix
approved these changes
Dec 5, 2025
Collaborator
echarlaix
left a comment
echarlaix
left a comment
There was a problem hiding this comment.
Thanks for iterating, feel free to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes
Add an extra value to input dict when wrapping infer request of a stateful model. This feature is not part of the latest NNCF v.2.19 release and depends on NNCF develop version.
Reason for changes
Quantization quality of stateful Whisper models is poor because a state of a stateful model must be cleared with the same schedule as it is done during calibration input data collection.
Ticket CVS-172705
Before submitting