-
Notifications
You must be signed in to change notification settings - Fork 87
Bump optimum to 2.0 #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump optimum to 2.0 #1018
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
dacorvo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this pull-request !
Unless I am mistaken, starting with optimum 2.0 we must not have any __init__.py at the top level (i.e. under optimum/neuron: see the explanation.
Other than that, this looks good to me (still an issue with mobilenet in the CI).
|
Thanks @dacorvo, will fix the issue in CI. For the init file of neuron, as explained @IlyasMoutawwakil here: huggingface/optimum#2361 (comment), it seems that we don't need to remove it, the change only need to be done on the top level of Optimum main pkg. |
So I was mistaken 😉 |
dacorvo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !
What does this PR do?
Fixes #1015
Optimum released a major 2.0 version which detached some legacy code for backends unrelated to Neuron. The PR aims at supporting Optimum 2.0 and cleaning deprecated code.