Suggest jobs to use in run-slow
#39100
Conversation
ydshieh
force-pushed
the
better_workflows
branch
from
0ec25bf to
2631688
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Suggested jobs to run:\n |
|
Suggested jobs to run:\nrun-slow: bark bert autoround fbgemm_fp8 |
|
run-slow: bark, bert, autoround, fbgemm_fp8 |
1 similar comment
|
run-slow: bark, bert, autoround, fbgemm_fp8 |
|
This comment contains run-slow, running the specified jobs: models: ['models/bark', 'models/bert'] |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bark, bert, autoround, fbgemm_fp8 |
| @@ -0,0 +1,163 @@ | |||
| name: PR slow CI | |||
| on: | |||
| pull_request_target: | |||
There was a problem hiding this comment.
only pull_request_target and not checkout to PR branch manually later, safe!
| # Compute (from the added/modified files) the directories under `tests/`, `tests/models/` and `tests/quantization`to run tests. | ||
| # These are already with the prefix `models/` or `quantization/`, so we don't need to add them. | ||
| jobs_to_run = get_jobs_to_run() | ||
| jobs_to_run = [x.replace("models/", "").replace("quantization/", "") for x in jobs_to_run] | ||
| jobs_to_run = [job for job in jobs_to_run if check_name(job)] | ||
|
|
||
| if len(jobs_to_run) > MAX_NUM_JOBS_TO_SUGGEST: | ||
| jobs_to_run = jobs_to_run[:MAX_NUM_JOBS_TO_SUGGEST] | ||
|
|
||
| suggestion = f"{', '.join(jobs_to_run)}" | ||
|
|
||
| print(suggestion) |
There was a problem hiding this comment.
we are in this part.
Later on, we will remove utils/pr_slow_ci_models.py and only keep this file.
There was a problem hiding this comment.
which will run them by default?
| # Compute (from the added/modified files) the directories under `tests/`, `tests/models/` and `tests/quantization`to run tests. | ||
| # These are already with the prefix `models/` or `quantization/`, so we don't need to add them. | ||
| jobs_to_run = get_jobs_to_run() | ||
| jobs_to_run = [x.replace("models/", "").replace("quantization/", "") for x in jobs_to_run] | ||
| jobs_to_run = [job for job in jobs_to_run if check_name(job)] | ||
|
|
||
| if len(jobs_to_run) > MAX_NUM_JOBS_TO_SUGGEST: | ||
| jobs_to_run = jobs_to_run[:MAX_NUM_JOBS_TO_SUGGEST] | ||
|
|
||
| suggestion = f"{', '.join(jobs_to_run)}" | ||
|
|
||
| print(suggestion) |
There was a problem hiding this comment.
which will run them by default?
nono, just suggestion. I don't want to trigger GPU runs on each PR commit. And for security reason, we can't checkout to PR branch without team member explicitly leaving the comment. |
|
Hi @ydshieh , This workflow is adding the comment after every commit and even on a draft PR. It would be great if we can fix this as it's super annoying - probably only add the comment if the PR is approved so kind of suggesting the maintainers that run-slow before merging if required as the PR is approved. |
|
Hi @yaswanth19 The previous comment is deleted in the workflow, but one has to refresh page, don't know why it (page content refresh) could not be done automatically.
I tried to I will try to add the comment (and of course delete the previous one) only if the previous one is 30 minutes ago or longer. |
|
#39170 should make it better 🤗 |
|
Great feedback @yaswanth19 ! Completely 🤗 |
What does this PR do?