Skip to content

Conversation

BakerBunker
Copy link
Contributor

@BakerBunker BakerBunker commented Jul 4, 2025

What does this PR do?

Fixes #39214

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@eustlb @zucchini-nlp

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test? (just to make sure we don't have any regressions later on)

@zucchini-nlp
Copy link
Member

run-slow: whisper

Copy link
Contributor

github-actions bot commented Jul 7, 2025

This comment contains run-slow, running the specified jobs:

models: ['models/whisper']
quantizations: [] ...

@vasqu
Copy link
Contributor

vasqu commented Jul 18, 2025

@BakerBunker Are you still interested in this PR?

@BakerBunker
Copy link
Contributor Author

@BakerBunker Are you still interested in this PR?

yes, I'm a little busy these days.

@vasqu
Copy link
Contributor

vasqu commented Jul 21, 2025

No worries, take your time

@BakerBunker
Copy link
Contributor Author

@vasqu test case added

@vasqu
Copy link
Contributor

vasqu commented Aug 18, 2025

Thanks, checking with models that might be affected then I'll merge

@vasqu
Copy link
Contributor

vasqu commented Aug 18, 2025

run-slow: qwen2_5_omni,qwen2_audio,voxtral,whisper

Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: whisper

Copy link
Contributor

This comment contains run-slow, running the specified jobs:

models: ['models/qwen2_5_omni', 'models/qwen2_audio', 'models/voxtral', 'models/whisper']
quantizations: [] ...

Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it does change the behavior of the models more than at least I expected. Can you add 🚨 to the title, as this is definitely a breaking change regardless.

Models:

  • Voxtral has no new failures
  • Same for qwen2 audio (although it just gets killed for whatever reason 👀)
  • Whisper has one new test failing (looks like not a high diff tho)
  • 2 new failures on qwen 2.5 omni cc @zucchini-nlp wdyt about the change?

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, oke for me as long as the tests in Qwen-Omni are updated before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistant input_feature length and attention_mask length in WhisperFeatureExtractor
3 participants