-
Notifications
You must be signed in to change notification settings - Fork 30.3k
Fix Inconsistant input_feature
length and attention_mask
length in WhisperFeatureExtractor
#39221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test? (just to make sure we don't have any regressions later on)
run-slow: whisper |
This comment contains run-slow, running the specified jobs: models: ['models/whisper'] |
@BakerBunker Are you still interested in this PR? |
yes, I'm a little busy these days. |
No worries, take your time |
@vasqu test case added |
Thanks, checking with models that might be affected then I'll merge |
run-slow: qwen2_5_omni,qwen2_audio,voxtral,whisper |
[For maintainers] Suggested jobs to run (before merge) run-slow: whisper |
This comment contains run-slow, running the specified jobs: models: ['models/qwen2_5_omni', 'models/qwen2_audio', 'models/voxtral', 'models/whisper'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it does change the behavior of the models more than at least I expected. Can you add 🚨 to the title, as this is definitely a breaking change regardless.
Models:
- Voxtral has no new failures
- Same for qwen2 audio (although it just gets killed for whatever reason 👀)
- Whisper has one new test failing (looks like not a high diff tho)
- 2 new failures on qwen 2.5 omni cc @zucchini-nlp wdyt about the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, oke for me as long as the tests in Qwen-Omni are updated before merging
What does this PR do?
Fixes #39214
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@eustlb @zucchini-nlp
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.