Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #36627 (issue #36626) where that PR misdiagnosed the underlying issue. The reason it wouldn't save is that the output_dir didn't exist yet because it was created in the checkpoint/optimizer save method. This fixes the issue by moving the checkpoint dir creation to the top.
Additionally, because
self.save_model
only handles FSDP FULL_STATE_DICT, and SHARDED_STATE_DICT is only handled during_save_optimizer_and_scheduler
which is gated bynot self.args.save_only_model
, we also need to manually handle saving the SHARDED_STATE_DICT for the edge case.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @S1ro1
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.