Skip to content

Conversation

winglian
Copy link
Contributor

@winglian winglian commented Aug 15, 2025

What does this PR do?

Follow up to #36627 (issue #36626) where that PR misdiagnosed the underlying issue. The reason it wouldn't save is that the output_dir didn't exist yet because it was created in the checkpoint/optimizer save method. This fixes the issue by moving the checkpoint dir creation to the top.

Additionally, because self.save_model only handles FSDP FULL_STATE_DICT, and SHARDED_STATE_DICT is only handled during _save_optimizer_and_scheduler which is gated by not self.args.save_only_model, we also need to manually handle saving the SHARDED_STATE_DICT for the edge case.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @S1ro1
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@S1ro1 S1ro1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S1ro1 S1ro1 enabled auto-merge (squash) August 19, 2025 15:02
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not sure if we already have a test, if not would be nice to add one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants