Skip to content

✨ Add logging for training completion and model saving in training scripts #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 30, 2025
Merged

✨ Add logging for training completion and model saving in training scripts #4048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be419de
✨ Add logging for training completion and model saving in training sc…
qgallouedec Sep 9, 2025
1eda699
Merge branch 'main' into print-trl-cli
qgallouedec Sep 11, 2025
e74406a
Merge branch 'main' into print-trl-cli
qgallouedec Sep 23, 2025
a95e92f
Merge branch 'main' into print-trl-cli
qgallouedec Sep 23, 2025
9e654ae
Merge branch 'main' into print-trl-cli
qgallouedec Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions trl/scripts/dpo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,21 @@ def main(script_args, training_args, model_args, dataset_args):
# Train the model
trainer.train()

# Log training complete
trainer.accelerator.print("✅ Training completed.")

if training_args.eval_strategy != "no":
metrics = trainer.evaluate()
trainer.log_metrics("eval", metrics)
trainer.save_metrics("eval", metrics)

# Save and push to Hub
trainer.save_model(training_args.output_dir)
trainer.accelerator.print(f"💾 Model saved to {training_args.output_dir}.")

if training_args.push_to_hub:
trainer.push_to_hub(dataset_name=script_args.dataset_name)
trainer.accelerator.print(f"🤗 Model pushed to the Hub in https://huggingface.co/{trainer.hub_model_id}.")


def make_parser(subparsers: Optional[argparse._SubParsersAction] = None):
Expand Down
6 changes: 6 additions & 0 deletions trl/scripts/grpo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,16 @@ def main(script_args, training_args, model_args, dataset_args):
# Train the model
trainer.train()

# Log training complete
trainer.accelerator.print("✅ Training completed.")

# Save and push to Hub
trainer.save_model(training_args.output_dir)
trainer.accelerator.print(f"💾 Model saved to {training_args.output_dir}.")

if training_args.push_to_hub:
trainer.push_to_hub(dataset_name=script_args.dataset_name)
trainer.accelerator.print(f"🤗 Model pushed to the Hub in https://huggingface.co/{trainer.hub_model_id}.")


def make_parser(subparsers: Optional[argparse._SubParsersAction] = None):
Expand Down
6 changes: 6 additions & 0 deletions trl/scripts/kto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,16 @@ def main(script_args, training_args, model_args, dataset_args):
# Train the model
trainer.train()

# Log training complete
trainer.accelerator.print("✅ Training completed.")

# Save and push to Hub
trainer.save_model(training_args.output_dir)
trainer.accelerator.print(f"💾 Model saved to {training_args.output_dir}.")

if training_args.push_to_hub:
trainer.push_to_hub(dataset_name=script_args.dataset_name)
trainer.accelerator.print(f"🤗 Model pushed to the Hub in https://huggingface.co/{trainer.hub_model_id}.")


def make_parser(subparsers: Optional[argparse._SubParsersAction] = None):
Expand Down
6 changes: 6 additions & 0 deletions trl/scripts/rloo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,16 @@ def main(script_args, training_args, model_args, dataset_args):
# Train the model
trainer.train()

# Log training complete
trainer.accelerator.print("✅ Training completed.")

# Save and push to Hub
trainer.save_model(training_args.output_dir)
trainer.accelerator.print(f"💾 Model saved to {training_args.output_dir}.")

if training_args.push_to_hub:
trainer.push_to_hub(dataset_name=script_args.dataset_name)
trainer.accelerator.print(f"🤗 Model pushed to the Hub in https://huggingface.co/{trainer.hub_model_id}.")


def make_parser(subparsers: Optional[argparse._SubParsersAction] = None):
Expand Down
6 changes: 6 additions & 0 deletions trl/scripts/sft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,16 @@ def main(script_args, training_args, model_args, dataset_args):
# Train the model
trainer.train()

# Log training complete
trainer.accelerator.print("✅ Training completed.")

# Save and push to Hub
trainer.save_model(training_args.output_dir)
trainer.accelerator.print(f"💾 Model saved to {training_args.output_dir}.")

if training_args.push_to_hub:
trainer.push_to_hub(dataset_name=script_args.dataset_name)
trainer.accelerator.print(f"🤗 Model pushed to the Hub in https://huggingface.co/{trainer.hub_model_id}.")


def make_parser(subparsers: Optional[argparse._SubParsersAction] = None):
Expand Down
Loading