-
Notifications
You must be signed in to change notification settings - Fork 2.2k
👩🦯 Fix usage of VLM using text only #4080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👩🦯 Fix usage of VLM using text only #4080
Conversation
test_vlm_text_only_issue.py
Outdated
@@ -0,0 +1,31 @@ | |||
"""Test for issue #3957 - VLM KeyError fix""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be deleted before merging
cc @qgallouedec for review when you get the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
We could add a modified version of the script as a test in test_sft_trainer.py
and remove the script
Thanks for your quick reply @sergiopaniego ! Good to merge on my side (but it looks like we still need approval for the workflows to run) |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@sergiopaniego do you understand why the tests are failing ? It doesn't look related to my changes ... :x |
Hi, thanks for your contribution. I opted for a different approach: when the dataset does not contain images, it can be pre-processed, and there is no point in doing it on the fly. |
This works as well! Thanks for the edit @qgallouedec. |
What
How to review
Test performed
[rank0]: KeyError: 'images'
like in sft_gemma3 example doesn't work #3957 but after the fix it is working just fine