Skip to content

Conversation

@albertvillanova
Copy link
Member

Fix PEFT interlinks in docstrings

The interlink will be properly rendered (as it is already the case for other HF libs, like transformers or datasets) once this PR in doc-builder is merged:

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Function to preprocess the logits before computing the metrics. Must take in the `logits` and `labels` and
return the logits to be used for metrics computation.
peft_config ([`~peft.config.PeftConfig`], *optional*):
peft_config ([`~peft.PeftConfig`], *optional*):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a similar mistake in PPO as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, I had missed that! 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ideally if you can fix ppo doctoring as well 🙏

@albertvillanova albertvillanova merged commit c8a5add into huggingface:main Sep 30, 2025
9 of 10 checks passed
qgallouedec added a commit that referenced this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants