refactor batchTransferFractionTest

[tnkshuuhei]

No description provided.

[github-actions]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

• shadowing-local (2 results) (Low)
• calls-loop (2 results) (Low)
• reentrancy-events (1 results) (Low)

shadowing-local

Impact: Low
Confidence: High

• ID-0
  IHypercertToken.mintClaimWithFractions(address,uint256,uint256[],string,IHypercertToken.TransferRestrictions).uri shadows:
  • IHypercertToken.uri(uint256) (function)

protocol-periphery/src/interfaces/IHypercertToken.sol

Line 29 in faca74c

string memory uri,

• ID-1
  IHypercertToken.mintClaim(address,uint256,string,IHypercertToken.TransferRestrictions).uri shadows:
  • IHypercertToken.uri(uint256) (function)

protocol-periphery/src/interfaces/IHypercertToken.sol

Line 21 in faca74c

function mintClaim(address account, uint256 units, string memory uri, TransferRestrictions restrictions) external;

calls-loop

Impact: Low
Confidence: Medium

• ID-2
  BatchTransferFraction._batchTransfer(address[],uint256[]) has external calls inside a loop: require(bool,error)(hypercertToken.ownerOf(fractionId) == msg.sender,revert INVALID_CALLER(address)(msg.sender))
  Calls stack containing the loop:
  BatchTransferFraction.batchTransfer(bytes)

protocol-periphery/src/BatchTransferFraction.sol

Lines 42 to 52 in faca74c

	function _batchTransfer(address[] memory recipients, uint256[] memory fractionIds) internal {
	uint256 length = recipients.length;
	for (uint256 i = 0; i < length; i++) {
	address recipient = recipients[i];
	uint256 fractionId = fractionIds[i];
	require(hypercertToken.ownerOf(fractionId) == msg.sender, INVALID_CALLER(msg.sender));
	hypercertToken.safeTransferFrom(msg.sender, recipient, fractionId, 1, "");
	}
	emit BatchFractionTransfer(msg.sender, recipients, fractionIds);
	}

• ID-3
  BatchTransferFraction._batchTransfer(address[],uint256[]) has external calls inside a loop: hypercertToken.safeTransferFrom(msg.sender,recipient,fractionId,1,)
  Calls stack containing the loop:
  BatchTransferFraction.batchTransfer(bytes)

protocol-periphery/src/BatchTransferFraction.sol

Lines 42 to 52 in faca74c

	function _batchTransfer(address[] memory recipients, uint256[] memory fractionIds) internal {
	uint256 length = recipients.length;
	for (uint256 i = 0; i < length; i++) {
	address recipient = recipients[i];
	uint256 fractionId = fractionIds[i];
	require(hypercertToken.ownerOf(fractionId) == msg.sender, INVALID_CALLER(msg.sender));
	hypercertToken.safeTransferFrom(msg.sender, recipient, fractionId, 1, "");
	}
	emit BatchFractionTransfer(msg.sender, recipients, fractionIds);
	}

reentrancy-events

Impact: Low
Confidence: Medium

• ID-4
  Reentrancy in BatchTransferFraction._batchTransfer(address[],uint256[]):
  External calls:
  • hypercertToken.safeTransferFrom(msg.sender,recipient,fractionId,1,)
    Event emitted after the call(s):
  • BatchFractionTransfer(msg.sender,recipients,fractionIds)

protocol-periphery/src/BatchTransferFraction.sol

Lines 42 to 52 in faca74c

	function _batchTransfer(address[] memory recipients, uint256[] memory fractionIds) internal {
	uint256 length = recipients.length;
	for (uint256 i = 0; i < length; i++) {
	address recipient = recipients[i];
	uint256 fractionId = fractionIds[i];
	require(hypercertToken.ownerOf(fractionId) == msg.sender, INVALID_CALLER(msg.sender));
	hypercertToken.safeTransferFrom(msg.sender, recipient, fractionId, 1, "");
	}
	emit BatchFractionTransfer(msg.sender, recipients, fractionIds);
	}

[github-actions]

Coverage after merging refactor/batchtransferTest into main will be

100.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
BatchTransferFraction.sol	100%	100%	100%	100%