-
Notifications
You must be signed in to change notification settings - Fork 339
Remove Bootstrap Icons #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Bootstrap Icons #1480
Conversation
🦋 Changeset detectedLatest commit: 3276ffc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
E2E Test Results✅ All tests passed • 46 passed • 3 skipped • 261s
|
Code Review✅ No critical issues found. This PR successfully migrates from Bootstrap Icons to Tabler Icons. The changes are comprehensive and well-executed: Strengths:
Minor observations (non-blocking):
The migration is complete and ready to merge. |
pulpdrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! It looks good except for a few minor size and alignment issues
|
@pulpdrew all issues have been addressed except the webhook icon - I'll make a ticket for this! |
This PR removes bootstrap-icons entirely from the app. It also adds an eslint plugin to detect uses and throw an error, this will help in the immediate short term with PRs in flight and merging downstream.
Fixes HDX-3050