Added connect-ip (RFC9484) as a known HTTP/3 CONNECT protocol #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no tests, what else would be needed for a review? |
I do not rally like the current solution wich requires each protocol to be known by h3. IMO it would be better if users of h3 can decide which protocol headers are known to them. |
|
So, does this mean this well done plumbing of the important connect-ip protocol which would work immediately isn't going to be reviewed and merged until after h3 has been rewritten to provide an API for extensions in the coming years? |
seanmonstar
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly trivial update to recognize connect-ip as a valid :protocol.