-
Notifications
You must be signed in to change notification settings - Fork 219
feat: extend the paradexsepolia USDC route to modetestnet #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: fedc37a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Check Warp Deploy Summary
Last updated: 2025-07-24 12:15:14 UTC |
📝 WalkthroughWalkthroughA new changeset was added to document a minor update to the USDC paradexsepolia route, now including the modetestnet network. Deployment and configuration files were updated to define the modetestnet token, add its connections, and adjust related deployment properties for solanatestnet. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Registry
participant modetestnet
participant paradexsepolia
participant sepolia
participant solanatestnet
participant starknetsepolia
User->>Registry: Query USDC paradexsepolia route
Registry->>modetestnet: Include new token details
Registry->>paradexsepolia: Update connections to modetestnet
Registry->>sepolia: Update connections to modetestnet
Registry->>solanatestnet: Update connections and foreignDeployment
Registry->>starknetsepolia: Update connections to modetestnet
Registry-->>User: Return updated route info
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- token: ethereum|solanatestnet|ETai5iFvKgAmLGSQrXgdMaMivQQ8Vn1xPRLBrRWtfmEo | ||
- token: ethereum|starknetsepolia|0x02abbcd42d5d38dc0a0ae1bc186bef271527ceeba3ff5e2bd3003800b80ebb1a | ||
decimals: 6 | ||
name: USDC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add logoURI
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/honest-ants-shout.md (1)
5-6
: Tighten the changeset summary a smidgeA brief sentence is grand, but it can help future ogres if you mention the new chain (
modetestnet
) in the same breath as the route being extended. Something like:Extend the USDC paradexsepolia warp route to the new modetestnet synthetic chain.
Purely a readability polish—no functional bite.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/honest-ants-shout.md
(1 hunks)deployments/warp_routes/USDC/paradexsepolia-config.yaml
(4 hunks)deployments/warp_routes/USDC/paradexsepolia-deploy.yaml
(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
deployments/warp_routes/USDC/paradexsepolia-config.yaml (1)
Learnt from: Xaroz
PR: #968
File: deployments/warp_routes/wpFLT/fluence-config.yaml:9-9
Timestamp: 2025-06-17T21:07:03.874Z
Learning: In warp route configurations, logos can be shared between different routes (like FLT and wpFLT) by referencing the same logoURI path to avoid duplication when the logos are identical. This is a preferred practice to avoid unnecessary asset duplication.
🔇 Additional comments (3)
deployments/warp_routes/USDC/paradexsepolia-deploy.yaml (1)
1-5
: Confirm whethergas
orowner
fields are expected for synthetic deploymentsOther synthetic entries (if any) in this marsh might include extra metadata like
gas
orowner
. If the tooling’s happy without them, ignore this swamp-dweller; otherwise you might need to add comparable keys for consistency.deployments/warp_routes/USDC/paradexsepolia-config.yaml (2)
4-14
: Mind the standard ↔ type alignmentYou’ve marked the token as
EvmHypSynthetic
here, andtype: synthetic
in the deploy file—those two line up well. Just give the docs a quick glance to ensureEvmHypSynthetic
is indeed the blessed standard name; the registry has bounced back before on subtle casing slips.
58-62
: Reciprocal links look goodNice job weaving the new modetestnet address back into every other chain’s connection list. The web is tight and symmetrical—no loose vines spotted.
- addressOrDenom: "0x1e2de04727e50d3F40f5558461741ea503872B21" | ||
chainName: modetestnet | ||
connections: | ||
- token: ethereum|paradexsepolia|0x05f971c4faecde2c2b8f2462ea9e5c72aa28ee64404c95e4b7b281e7b49142fb | ||
- token: ethereum|sepolia|0xFE5505d75890122A6624EEE2ce6C075c421e1849 | ||
- token: ethereum|solanatestnet|ETai5iFvKgAmLGSQrXgdMaMivQQ8Vn1xPRLBrRWtfmEo | ||
- token: ethereum|starknetsepolia|0x02abbcd42d5d38dc0a0ae1bc186bef271527ceeba3ff5e2bd3003800b80ebb1a | ||
decimals: 6 | ||
name: USDC | ||
standard: EvmHypSynthetic | ||
symbol: USDC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add logoURI
to the new modetestnet token
Every other USDC cousin carries a logoURI
pointing at /deployments/warp_routes/USDC/logo.svg
. The fresh modetestnet entry is missing that breadcrumb. Dropping it in keeps the herd uniform and avoids UI hiccups downstream.
symbol: USDC
+ logoURI: /deployments/warp_routes/USDC/logo.svg
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- addressOrDenom: "0x1e2de04727e50d3F40f5558461741ea503872B21" | |
chainName: modetestnet | |
connections: | |
- token: ethereum|paradexsepolia|0x05f971c4faecde2c2b8f2462ea9e5c72aa28ee64404c95e4b7b281e7b49142fb | |
- token: ethereum|sepolia|0xFE5505d75890122A6624EEE2ce6C075c421e1849 | |
- token: ethereum|solanatestnet|ETai5iFvKgAmLGSQrXgdMaMivQQ8Vn1xPRLBrRWtfmEo | |
- token: ethereum|starknetsepolia|0x02abbcd42d5d38dc0a0ae1bc186bef271527ceeba3ff5e2bd3003800b80ebb1a | |
decimals: 6 | |
name: USDC | |
standard: EvmHypSynthetic | |
symbol: USDC | |
- addressOrDenom: "0x1e2de04727e50d3F40f5558461741ea503872B21" | |
chainName: modetestnet | |
connections: | |
- token: ethereum|paradexsepolia|0x05f971c4faecde2c2b8f2462ea9e5c72aa28ee64404c95e4b7b281e7b49142fb | |
- token: ethereum|sepolia|0xFE5505d75890122A6624EEE2ce6C075c421e1849 | |
- token: ethereum|solanatestnet|ETai5iFvKgAmLGSQrXgdMaMivQQ8Vn1xPRLBrRWtfmEo | |
- token: ethereum|starknetsepolia|0x02abbcd42d5d38dc0a0ae1bc186bef271527ceeba3ff5e2bd3003800b80ebb1a | |
decimals: 6 | |
name: USDC | |
standard: EvmHypSynthetic | |
symbol: USDC | |
logoURI: /deployments/warp_routes/USDC/logo.svg |
🤖 Prompt for AI Agents
In deployments/warp_routes/USDC/paradexsepolia-config.yaml around lines 4 to 14,
the new modetestnet token entry is missing the logoURI field that other USDC
tokens have. Add a logoURI property with the value
/deployments/warp_routes/USDC/logo.svg to this token's configuration to maintain
consistency and prevent UI issues.
Description
Backward compatibility
Testing
Summary by CodeRabbit