-
Notifications
You must be signed in to change notification settings - Fork 214
chore: add oUSDT coingecko Id #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8e854c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the gecko id only needed on collateral chains, which we already do?
coinGeckoId: tether |
coinGeckoId: tether |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure
but it uses a different symbol (USDT), and therefore I'm not able to map a coingecko-Id to oUSDT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting - in most cases we keep the collateral/token name the same but for ousdt it's intentional that you'd have a different collateral name to the token
i feel for accurate metrics here we should be using tether
as that's the underlying token, but if you need ousdt
then that's fine with me too. you'll only need to update ethereum
and celo
for this though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no preference here. So right now for analytics we use the data in the configs to map a coingecko id to a symbol. I think openusdt and usdt should almost always be the same value.
Is it safe to use the folder name for the symbol and then the first coingecko-id I can find in the files?
Are there some examples where deployments have different prices on source and destination chains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to use the folder name for the symbol and then the first coingecko-id I can find in the files?
yup I think this should be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok lets stick with ousdt
then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks, yeah I think we can close this then
Check Warp Deploy Summary Check Warp Deploy Summary
Last updated: 2025-06-23 12:43:56 UTC |
Description
Backward compatibility
Yes