Skip to content

Conversation

mbreithecker
Copy link
Contributor

Description

Backward compatibility

Yes

@mbreithecker mbreithecker requested a review from paulbalaji June 23, 2025 12:41
Copy link

changeset-bot bot commented Jun 23, 2025

🦋 Changeset detected

Latest commit: 8e854c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperlane-xyz/registry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the gecko id only needed on collateral chains, which we already do?


Copy link
Contributor Author

@mbreithecker mbreithecker Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure
but it uses a different symbol (USDT), and therefore I'm not able to map a coingecko-Id to oUSDT.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting - in most cases we keep the collateral/token name the same but for ousdt it's intentional that you'd have a different collateral name to the token

i feel for accurate metrics here we should be using tether as that's the underlying token, but if you need ousdt then that's fine with me too. you'll only need to update ethereum and celo for this though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no preference here. So right now for analytics we use the data in the configs to map a coingecko id to a symbol. I think openusdt and usdt should almost always be the same value.

Is it safe to use the folder name for the symbol and then the first coingecko-id I can find in the files?
Are there some examples where deployments have different prices on source and destination chains?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to use the folder name for the symbol and then the first coingecko-id I can find in the files?

yup I think this should be fine

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lets stick with ousdt then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, yeah I think we can close this then

Copy link
Contributor

Check Warp Deploy Summary

Check Warp Deploy Summary

Warp Route ID Status
oUSDT/production

Last updated: 2025-06-23 12:43:56 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants