dlog v1 finalization: unit-tests coverage above 80% - token #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
force-pushed
the
f-933-token
branch
2 times, most recently
from
df79064 to
2ff7bb6
Compare
adecaro
force-pushed
the
f-933-token
branch
2 times, most recently
from
d2fbba9 to
e989579
Compare
| { | ||
| name: "publicParams cannot be nil", | ||
| init: func() (logging.Logger, *setup.PublicParams, token2.IdentityDeserializer, error) { | ||
| return nil, nil, nil, nil |
There was a problem hiding this comment.
do we need to return the logger? we could use some default or nil value always, or are we testing something?
alexandrosfilios
approved these changes
Jul 1, 2025
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { |
There was a problem hiding this comment.
I think that using matrices here makes the tests more complex. The amount of re-usable code is negligible, so I would inline the tests, e.g.
func Test_Success(t *testing.T) {
RegisterTestingT(t)
id := &mock.IdentityDeserializer{}
id.RecipientsReturns([]driver.Identity{driver.Identity("alice")}, nil)
ts, err := token2.NewTokensService(nil, pp, id)
Expect(err).ToNot(HaveOccurred())
tok := &token2.Token{}
raw, err := tok.Serialize()
Expect(err).ToNot(HaveOccurred())
identities, err := ts.Recipients(raw)
Expect(err).ToNot(HaveOccurred())
Expect(identities).To(ConsistOf(driver.Identity("Alice"))
}
There was a problem hiding this comment.
This way also your errors can become more descriptive, e.g.
Expect(err).To(ContainSubstring(...))
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.