dlog token driver: improve the use of mathlib #1287 #1288
Conversation
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
| bls12381.NewBls12_381BBS().G2ByteSize(), | ||
| bls12381.NewBls12_381BBS().CompressedG2ByteSize(), | ||
| bls12381.NewBls12_381BBS().ScalarByteSize(), | ||
| BLS12_381_BBS_GURVY_FAST_RNG, |
There was a problem hiding this comment.
Is that something that we need to tune during testing? or does this fix? (does it worth to have it in config file)?
|
|
||
| import "encoding/binary" | ||
|
|
||
| // AppendFixed32 appends slices prefixed with a 4-byte Little Endian length. |
There was a problem hiding this comment.
Little Endian this means that we support only x86 not power/z deployments?
| require.NoError(t, err) | ||
| } | ||
|
|
||
| func BenchmarkIPAProver(b *testing.B) { |
There was a problem hiding this comment.
Do we have doc. of what this function does?
| } | ||
|
|
||
| // Comparison: Naive Loop (No pre-calculation) | ||
| func BenchmarkAppendFixed32_Naive(b *testing.B) { |
There was a problem hiding this comment.
Could you please add doc to this one?
It is not clear to me what this benchmarks tests and how to connect it to the Approver performance?
| } | ||
| raw[i] = e.Bytes() | ||
| } | ||
| clear(b) |
There was a problem hiding this comment.
What does the clear do? Is that ok to clear the "b" here? what happen if the caller needs it? Maybe to add flag to clear and this will be clear to the caller.
| } | ||
| raw[i] = e.Bytes() | ||
| } | ||
| clear(b) |
| assert.NoError(t, err) | ||
| } | ||
|
|
||
| func BenchmarkBFProver(b *testing.B) { |
There was a problem hiding this comment.
Same as other comment need to document this (need to understand what this does)
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
No description provided.