Sketch: token API proxy #1907
Draft
Sketch: token API proxy #1907
+363
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[no ci]
| provider : Party -- ^ The app provider whose featured app right should be triggered | ||
| providerWeight : Decimal -- ^ Reward weight for the provider | ||
| userWeight : Decimal -- ^ Reward weight for the user, set to 0.0 if the user should not receive a reward | ||
| extraBeneficiaries : [AppRewardBeneficiary] -- ^ Extra beneficiaries to list |
There was a problem hiding this comment.
Suggested change
| extraBeneficiaries : [AppRewardBeneficiary] -- ^ Extra beneficiaries to list | |
| extraBeneficiaries : [AppRewardBeneficiary] -- ^ Extra beneficiaries to list. The full list of beneficiaries for the created app marker will include the provider and user (if weight > 0) + the extraBeneficiaries. Note that these beneficiaries only affect the app marker not the transfer which in the case of CC may generate separate rewards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketch for a solution of #1901
[no ci]
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines