Skip to content

Conversation

meiersi-da
Copy link
Contributor

PR for alignment purposes. Daml tests are passing.

It's not really no pre-approval fee, but rather a free base duration. This provides a simpler experience for creating a pre-approval as any party, while still allowing long-duration pre-approvals where required. I could see us offering a similar UX for directory entries.

The fetching of the OpenMiningRound is unfortunate, but doesn't seem a bigger obstacle here than it is in other places.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks

@meiersi-da meiersi-da changed the title DRAFT: daml - no preapproval fee DRAFT: daml - adjust preapproval fee Aug 19, 2025
@meiersi-da meiersi-da force-pushed the meiersi/daml/no-preapproval-fee branch from 8c0f0f9 to c362763 Compare August 19, 2025 15:12
@meiersi-da meiersi-da force-pushed the meiersi/daml/no-preapproval-fee branch from c362763 to b4c4146 Compare August 19, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants