Skip to content

Conversation

pawelperek-da
Copy link

@pawelperek-da pawelperek-da commented Aug 27, 2025

Fixes #1943

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Paweł Perek <[email protected]>
@ray-roestenburg-da
Copy link
Contributor

ray-roestenburg-da commented Aug 27, 2025

Please add a test that shows that in both cases the expiration now shows correctly.

@pawelperek-da
Copy link
Author

Zrzut ekranu 2025-08-27 o 14 28 01

@fayi-da
Copy link
Contributor

fayi-da commented Aug 27, 2025

+1 for test. Small vitest test to complete the form, take note of the "expires" text, click the button, compare the time showed there

@OriolMunoz-da OriolMunoz-da removed their request for review August 27, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expiration difference between form and confirmation dialog in sv ui
3 participants