WIP: Expose mediator-scan API through the Scan app #2039
+904
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
| @@ -0,0 +1,55 @@ | |||
| -- Table 1: scan_verdict_store | |||
There was a problem hiding this comment.
nitpick: I would remove the table 1: and table 2: from these comments
|
|
||
| -- Index for efficient querying by migration, domain, and record time | ||
| create index scan_verdict_mi_di_rt on scan_verdict_store (migration_id, domain_id, record_time); | ||
| create index scan_verdict_di_mi_rt on scan_verdict_store (domain_id, migration_id, record_time); |
There was a problem hiding this comment.
in which case is this index needed, why does scan_verdict_mi_di_rt not suffice?
| required: true | ||
| schema: | ||
| type: string | ||
| - name: "lossless" |
There was a problem hiding this comment.
This should not be used (was part of a deprecated version of updates, /v0/updates), please follow example of /v2/updates/{update_id} instead
| description: | | ||
| Returns the event with the given update_id. | ||
| parameters: | ||
| - name: "event_id" |
There was a problem hiding this comment.
Rather use update_id, since event_id also has a meaning in this API, but is used for something else
| )(extracted: TraceContext): Future[ScanResource.GetEventByIdResponse] = { | ||
| implicit val tc = extracted | ||
| withSpan(s"$workflowId.getEventById") { _ => _ => | ||
| val encoding = if (lossless.getOrElse(false)) { |
There was a problem hiding this comment.
do this like getUpdateByIdV2 instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP branch with implementation for new scan-app endpoint
/v0/eventsto provide data from mediator-scan API.Fixes #1564
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines