Prevent AmuletRules_BuyMemberTraffic from causing flakes #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci] Signed-off-by: Oriol Muñoz <[email protected]>
rautenrieth-da
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Looks sensible, thanks!
Should we also check all other occurences of .listTransactions in *Test.scala? This one for example looks like it could be affected as well.
that's from scan though there are some for some validator wallets where this can still happen, so adding it to those |
Signed-off-by: Oriol Muñoz <[email protected]>
Signed-off-by: Oriol Muñoz <[email protected]>
Signed-off-by: Oriol Muñoz <[email protected]>
Signed-off-by: Oriol Muñoz <[email protected]>
hrischuk-da
pushed a commit
to hrischuk-da/splice
that referenced
this pull request
Aug 29, 2025
…-labs#2046) --------- Signed-off-by: Oriol Muñoz <[email protected]> Signed-off-by: hrischuk-da <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/DACH-NY/cn-test-failures/issues/5436