Fix createTransferPreapproval timing out in tests #2064
Merged
+51
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't because it didn't have funds, but because the validator took too long to accept the preapproval and the walletclient timed out [ci] Signed-off-by: Oriol Muñoz <[email protected]>
|
note: only showed up in one test, but I expect others have the same potential |
Signed-off-by: Oriol Muñoz <[email protected]>
hrischuk-da
pushed a commit
to hrischuk-da/splice
that referenced
this pull request
Aug 29, 2025
) This wasn't because it didn't have funds, but because the validator took too long to accept the preapproval and the walletclient timed out Signed-off-by: Oriol Muñoz <[email protected]> Signed-off-by: hrischuk-da <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/DACH-NY/cn-test-failures/issues/5437
This wasn't because it didn't have funds, but because the validator took too long to accept the preapproval and the walletclient timed out.