-
Notifications
You must be signed in to change notification settings - Fork 41
Fix issue 2017: setting localhost as default in docker-compose based setups #2601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 2017: setting localhost as default in docker-compose based setups #2601
Conversation
…on to expose externally. [static] Signed-off-by: Pasindu Tennage <[email protected]>
…to chose between localhost and 0.0.0.0 [static] Signed-off-by: Pasindu Tennage <[email protected]>
…r deployment. Hardcoded to localhost, with no option to run externally. Since localnet only runs locally, no need to expose externally. [ci] Signed-off-by: Pasindu Tennage <[email protected]>
Looks reasonable to me, nice work @pasindutennage-da !
|
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
The CI error comes because the test is not exporting the |
The message was probably from stop.sh. You might want instead to just add HOST_BIND_IP here: splice/cluster/compose/validator/stop.sh Line 33 in 38602fd
|
Thanks! Changes lgtm overall, definitely should go in the release notes including mentioning the option to turn it back on. Also please ask someone on macos to test this (probably spin up localnet and check that you can still open the wallet or something like that) as we discussed in slack. Docker on macos can be a bit finicky |
Added release notes. Added LocalNet docker-compose the option to chose between 0.0.0.0 and 127.0.0.1 Added exports to stop.sh to avoie CI complains. [ci] Signed-off-by: Pasindu Tennage <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, thank you @pasindutennage-da !
Mainly to try it out (90% sure this doesn't break anything there), you might want to consider doing a (basic) cluster test as well before you merge: https://github.com/hyperledger-labs/splice/blob/main/TESTING.md#requesting-cluster-tests
...and actually, how annoying would it be to extend our integration tests for these flows to check that all opened ports are bound to localhost? I.e., |
From a quick look at the code there it looks like a reasonable investment; let's do this so we guard against regressions? |
…o only localhost, when used with docker compose. Updated release_notes. [ci] /cluster_test Signed-off-by: Pasindu Tennage <[email protected]>
Done. DockerComposeFullNetworkFrontendIntegrationTest checks for both SV and validator |
/cluster_test |
Deploy cluster test triggered for Commit bf1da1615f4f0df660f739c29f8f1cc4dbfbcbbf in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/36638 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
...tralizedtrust/splice/integration/tests/DockerComposeFullNetworkFrontendIntegrationTest.scala
Show resolved
Hide resolved
...tralizedtrust/splice/integration/tests/DockerComposeFullNetworkFrontendIntegrationTest.scala
Outdated
Show resolved
Hide resolved
Deploy cluster test triggered for Commit bf1da1615f4f0df660f739c29f8f1cc4dbfbcbbf in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/36741 |
…ntegTest [ci] Signed-off-by: Pasindu Tennage <[email protected]>
Basic cluster tests passes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Fixes #2017
Set localhost as the default in
SV
,localhost
, andvalidator
docker-compose incluster/compose
For
SV
andValidator
, there is an option to expose externally using-E
flag, in the respectivestart.sh
scripts.For
localnet
, it is hardcoded, because no extra traffic is expected.