Fix issue 2017: setting localhost as default in docker-compose based setups

[pasindutennage-da]

Fixes #2017

Set localhost as the default in SV, localhost, and validator docker-compose in cluster/compose

For SV and Validator, there is an option to expose externally using -E flag, in the respective start.sh scripts.

For localnet, it is hardcoded, because no extra traffic is expected.

[martinflorian-da]

Looks reasonable to me, nice work @pasindutennage-da !

1. CI is unhappy, AFAICT due to the log checker. Ideally you can avoid the problematic log; it looks like the better option in this case (the other option being adding it to the right "ignore" file):

Found problems in the sbt output:
time="2025-10-08T15:17:21Z" level=warning msg="The \"HOST_BIND_IP\" variable is not set. Defaulting to a blank string."
time="2025-10-08T15:17:23Z" level=warning msg="The \"HOST_BIND_IP\" variable is not set. Defaulting to a blank string."
Total: 2 lines with problems.

2. This looks to me like a change we should make more public. How about adding something to docs/src/release_notes.rst?

[pasindutennage-da]

The CI error comes because the test is not exporting the HOST_BIND_IP correclty. I made a revision, and now if the variable is not set, it uses the default value.

[isegall-da]

The CI error comes because the test is not exporting the HOST_BIND_IP correclty. I made a revision, and now if the variable is not set, it uses the default value.

The message was probably from stop.sh. You might want instead to just add HOST_BIND_IP here:

splice/cluster/compose/validator/stop.sh

Line 33 in 38602fd

export VALIDATOR_NEW_PARTICIPANT_IDENTIFIER=""

(where we just export a bunch of env vars, for the exact purpose of avoiding these warnings)

[moritzkiefer-da]

Thanks! Changes lgtm overall, definitely should go in the release notes including mentioning the option to turn it back on.

Also please ask someone on macos to test this (probably spin up localnet and check that you can still open the wallet or something like that) as we discussed in slack. Docker on macos can be a bit finicky

[martinflorian-da]

Nice job, thank you @pasindutennage-da !

Mainly to try it out (90% sure this doesn't break anything there), you might want to consider doing a (basic) cluster test as well before you merge: https://github.com/hyperledger-labs/splice/blob/main/TESTING.md#requesting-cluster-tests

[martinflorian-da]

...and actually, how annoying would it be to extend our integration tests for these flows to check that all opened ports are bound to localhost?

I.e., DockerComposeFullNetworkFrontendIntegrationTest and DockerComposeValidatorFrontendIntegrationTest.

[martinflorian-da]

...and actually, how annoying would it be to extend our integration tests for these flows to check that all opened ports are bound to localhost?

I.e., DockerComposeFullNetworkFrontendIntegrationTest and DockerComposeValidatorFrontendIntegrationTest.

From a quick look at the code there it looks like a reasonable investment; let's do this so we guard against regressions?

[pasindutennage-da]

...and actually, how annoying would it be to extend our integration tests for these flows to check that all opened ports are bound to localhost?
I.e., DockerComposeFullNetworkFrontendIntegrationTest and DockerComposeValidatorFrontendIntegrationTest.

From a quick look at the code there it looks like a reasonable investment; let's do this so we guard against regressions?

Done. DockerComposeFullNetworkFrontendIntegrationTest checks for both SV and validator

[pasindutennage-da]

/cluster_test

[github-actions]

Deploy cluster test triggered for Commit bf1da1615f4f0df660f739c29f8f1cc4dbfbcbbf in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/36638

[martinflorian-da]

Nice work, thank you!

[pasindutennage-da]

/cluster_test

https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/36710

[github-actions]

Deploy cluster test triggered for Commit bf1da1615f4f0df660f739c29f8f1cc4dbfbcbbf in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/36741

[pasindutennage-da]

Nice job, thank you @pasindutennage-da !

Mainly to try it out (90% sure this doesn't break anything there), you might want to consider doing a (basic) cluster test as well before you merge: https://github.com/hyperledger-labs/splice/blob/main/TESTING.md#requesting-cluster-tests

Basic cluster tests passes

[martinflorian-da]

Looks great, thanks!