Skip to content

refactor: move target gas limit to network definition #9502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Gabriel-Trintinalia wants to merge 11 commits into
base: main
Choose a base branch
from
Open

refactor: move target gas limit to network definition #9502

Gabriel-Trintinalia wants to merge 11 commits into from
+176 −58

Conversation

@Gabriel-Trintinalia
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia commented Nov 27, 2025

PR description

  • Moves the default target gas limit to NetworkDefinition instead of MergeCoordinator.
  • Sets TargetGasLimit only when explicitly defined for a given chainId; otherwise, the genesis value is preserved.
  • Fixes ~50 RPC-compat Hive tests.

@Gabriel-Trintinalia
Move NetworkName to better package and rename it
99e148d 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Move default gas limit to network
2b2d675 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Move default gas limit to network
b7b565e 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
remove null
bf86bc3 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Merge main
4bbfe8b 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Add test
3b1af74 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Remove dependency
1d924e0 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Copilot AI review requested due to automatic review settings November 27, 2025 05:44
Copilot AI reviewed Nov 27, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as draft November 28, 2025 00:08
@github-project-automation github-project-automation bot moved this to Backlog in RC 25.12.0 Dec 4, 2025
@Gabriel-Trintinalia
Use chain id instead of network ID
b90c554 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Merge main
e400d14 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review December 10, 2025 04:54
macfarla
macfarla approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have tried this out locally with ephemery, hoodi and a local genesis and get the target gas limit expected. excited for the hive tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@macfarla macfarla macfarla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

RC 25.12.0
Status: Open PRs

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gabriel-Trintinalia @macfarla