update commons-lang to 3.18 #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I am nervous of forcing dependency resolution to pick a specific version. I wonder if a version constraint might be a more subtle approach:
dependencies {
constraints {
pmd('org.apache.commons:commons-lang3:3.18.0') {
because('CVE-2025-48924')
}
}
}This should allow future PMD versions to depend on newer versions of commons-lang3, while ensuring that a vulnerable version (earlier than 3.18.0) is not resolved. What do you think?
|
I agree. I’ll update the code accordingly. Thanks for the suggestion! |
Signed-off-by: Thomas Leung <[email protected]>
Thomas-Leung
force-pushed
the
security-patch
branch
from
6b83ac1 to
f7f75b8
Compare
|
bestbeforetoday
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A moderate-severity vulnerability was reported in commons-lang, a transitive dependency of pmd. Since the latest version of pmd does not yet include a patch, a pull request has been created as a temporary fix.
Reference: GHSA-j288-q9x7-2f5v