change request verifier to return request type #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HagarMeir
force-pushed
the
verifierReturnsConfig
branch
from
c738031 to
3b6f64f
Compare
Signed-off-by: Dor.Katzelnick <[email protected]>
HagarMeir
force-pushed
the
verifierReturnsConfig
branch
from
3b6f64f to
7a8a72d
Compare
tock-ibm
reviewed
Oct 26, 2025
Comment on lines
+93
to
+101
| switch common.HeaderType(chdr.Type) { | ||
| case common.HeaderType_CONFIG_UPDATE: | ||
| reqType = "config_update" | ||
| case common.HeaderType_CONFIG: | ||
| reqType = "config" | ||
| case common.HeaderType_MESSAGE: | ||
| reqType = "data" | ||
| default: | ||
| return nil, reqType, fmt.Errorf("request header type is not config or data") |
There was a problem hiding this comment.
Why won't we just use the enum as is? this way it is more readable; and we don't have to go through a custom translation of enum to string...
| rules []Rule | ||
| lock sync.RWMutex | ||
| rules []Rule | ||
| structureRules []StructureRule |
There was a problem hiding this comment.
Are we expecting more than one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.