Skip to content

Conversation

MarkMankins
Copy link

Description

Updated the build of jemalloc during the dgraph build to not require sudo.

  • Not requiring sudo makes the build available to users without sudo access on the build machine.
  • Previously the build would check for jemalloc in /usr/local/lib. There was no guarantee this was the expected version of jemalloc.
  • Build jemalloc in TMPDIR if it is set instead of hard-coding to /tmp.
  • Allow multiple users to build in TMPDIR by making the temporary directory name unique for each user.

This change requires a change to ristretto, since ristretto was hard-coded to look for jemalloc in /usr/local/lib. I would expect ci to fail since it will be building against an incompatible version of ristretto.

See: hypermodeinc/ristretto#469

I tested this locally (Red Hat & Ubuntu) with an updated ristretto by adding this to the dgraph go.mod file:

replace github.com/dgraph-io/ristretto/v2 => ../ristretto

For this to work I would expect that the ristretto changes would require ristretto be tagged with a new version number and the dgraph go.mod be updated to reference the new ristretto version number.

If there is anything else I can do on my end please let me know.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to
    this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo
    staged and linked here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant