build: Build jemalloc without sudo #9510
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the build of jemalloc during the dgraph build to not require sudo.
This change requires a change to ristretto, since ristretto was hard-coded to look for jemalloc in /usr/local/lib. I would expect ci to fail since it will be building against an incompatible version of ristretto.
See: hypermodeinc/ristretto#469
I tested this locally (Red Hat & Ubuntu) with an updated ristretto by adding this to the dgraph go.mod file:
replace github.com/dgraph-io/ristretto/v2 => ../ristretto
For this to work I would expect that the ristretto changes would require ristretto be tagged with a new version number and the dgraph go.mod be updated to reference the new ristretto version number.
If there is anything else I can do on my end please let me know.
Checklist
CHANGELOG.md
file describing and linking tothis PR
staged and linked here