Skip to content

feature: add check command to verify deployed endpoints #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feature: add check command to verify deployed endpoints #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bba772e
add check command to verify deployed endpoints
Anmol1696 Jun 25, 2024
2698169
add check command to require config
Anmol1696 Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion clients/js/packages/cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const questions: Question[] = params.map(name => ({ name, type: 'text' }));
// Filter questions based on the command
function getQuestionsForCommand(command: string): Question[] {
const commonQuestions = questions.filter(q => q.name !== 'config');
if (['start', 'deploy', 'start-ports', 'wait-for-pods'].includes(command)) {
if (['start', 'deploy', 'start-ports', 'wait-for-pods', 'check'].includes(command)) {
return questions; // Include all questions, including config
} else {
return commonQuestions; // Exclude config
Expand Down Expand Up @@ -103,6 +103,9 @@ async function main() {
case 'undeploy':
client.deleteHelm();
break;
case 'check':
client.check();
break;
default:
console.log(`Unknown command: ${command}`);
displayUsage();
Expand Down
6 changes: 6 additions & 0 deletions clients/js/packages/client/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,4 +595,10 @@ export class StarshipClient implements StarshipClientI {
console.log(pid);
});
}

public check(): void {
this.checkDependencies();
this.exec(['helm', 'version']);
this.exec(['kubectl', 'version', '--short']);
}
}