#259 - full tag to onAddition #260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps in custom tagComponent
8 tasks
jtojnar
added a commit
to fossar/selfoss
that referenced
this pull request
Jan 22, 2022
This will make tags added to a source have access to colour despite i-like-robots/react-tags#260 not being merged. Additionally, this will also update the colors when the tags are updated.
|
This will be the default behaviour in the next major version (which is in development here). However, I'm reluctant to make this change to the current version of the component because a change to the public interface should require releasing as a new major version. |
i-like-robots
force-pushed
the
main
branch
2 times, most recently
from
07a315c to
dbd521f
Compare
jtojnar
added a commit
to fossar/selfoss
that referenced
this pull request
Oct 14, 2022
This will make tags added to a source have access to colour despite i-like-robots/react-tags#260 not being merged. Additionally, this will also update the colors when the tags are updated.
|
Was this a breaking change not passing full tag? handleAdd supported this no? Quelle surprise |
|
Maybe until the new version is released, we could add an additional |
|
Closing as this feature is now supported in v7. |
jtojnar
added a commit
to fossar/selfoss
that referenced
this pull request
Jul 16, 2023
This will make tags added to a source have access to colour despite i-like-robots/react-tags#260 not being merged. Additionally, this will also update the colors when the tags are updated.
jtojnar
added a commit
to fossar/selfoss
that referenced
this pull request
Jul 16, 2023
This will make tags added to a source have access to colour despite i-like-robots/react-tags#260 not being merged. Additionally, this will also update the colors when the tags are updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#259 modify onAddition to pass full tag to allow use of additional tag props in custom tagComponent