Fixed compatibility issues with ESP32-2432S028R and Windows hosts #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this project, it's very cool! I had some trouble getting it set up on my ESP32-2432S028R, and some of the code also didn't work with a Windows host, so I made a bunch of changes to resolve those issues. You may not want to take all of these changes, as I'm not sure if they'll be compatible with the hardware you used when you originally developed this. It seems like there are some differences in which GPIO PINs are used, and the orientation of the display (I had to switch the width and the height in the code).
I'm happy to make further changes to make this more suitable for upstreaming, although I can't promise that I'll be able to do so quickly. Thought I'd just throw this out for now and see if you have any interest in merging it. If not, no hard feelings.
Full disclosure: much of this was vibe-coded with Claude Sonnet 4. But I did review the changes and verify that it works on my device.