Skip to content

Added protocol config to bypass certificates. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added protocol config to bypass certificates. #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/com/ibm/eventstreams/connect/elasticsink/ElasticSinkConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ public class ElasticSinkConnector extends SinkConnector {
public static final String CONFIG_DOCUMENTATION_ES_PASSWORD = "The password for authenticating with Elasticsearch.";
public static final String CONFIG_DISPLAY_ES_PASSWORD = "Password";

public static final String DEFAULT_ES_PROTOCOL = "http";
public static final String CONFIG_NAME_ES_PROTOCOL = "es.protocol";
public static final String CONFIG_DOCUMENTATION_ES_PROTOCOL = "The protocol to connect to Elasticsearch.";
public static final String CONFIG_DISPLAY_ES_PROTOCOL = "HTTP/ HTTPS";

public static final String CONFIG_NAME_ES_TLS_KEYSTORE_LOCATION = "es.tls.keystore.location";
public static final String CONFIG_DOCUMENTATION_ES_TLS_KEYSTORE_LOCATION = "The path to the JKS keystore to use for the TLS connection.";
public static final String CONFIG_DISPLAY_ES_TLS_KEYSTORE_LOCATION = "TLS keystore location";
Expand Down Expand Up @@ -210,6 +215,10 @@ public ConfigDef config() {
CONFIG_DOCUMENTATION_ES_PASSWORD, CONFIG_GROUP_ES, 3, Width.MEDIUM,
CONFIG_DISPLAY_ES_PASSWORD);

config.define(CONFIG_NAME_ES_PROTOCOL, Type.STRING, DEFAULT_ES_PROTOCOL, Importance.MEDIUM,
CONFIG_DOCUMENTATION_ES_PROTOCOL, CONFIG_GROUP_ES, 4, Width.MEDIUM,
CONFIG_DISPLAY_ES_PROTOCOL);

config.define(CONFIG_NAME_ES_TLS_KEYSTORE_LOCATION, Type.STRING, null, Importance.MEDIUM,
CONFIG_DOCUMENTATION_ES_TLS_KEYSTORE_LOCATION, CONFIG_GROUP_ES, 10, Width.MEDIUM,
CONFIG_DISPLAY_ES_TLS_KEYSTORE_LOCATION);
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/com/ibm/eventstreams/connect/elasticsink/ElasticWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public class ElasticWriter {
private String trustStore;
private String trustStorePassword;

private String protocol = "http";
private String protocol;
private String proxyHost = null;
private int proxyPort = 0;

Expand Down Expand Up @@ -107,6 +107,7 @@ public void configure(Map<String, String> props) throws ConnectException {
keyStorePassword = props.get(ElasticSinkConnector.CONFIG_NAME_ES_TLS_KEYSTORE_PASSWORD);
trustStore = props.get(ElasticSinkConnector.CONFIG_NAME_ES_TLS_TRUSTSTORE_LOCATION);
trustStorePassword = props.get(ElasticSinkConnector.CONFIG_NAME_ES_TLS_TRUSTSTORE_PASSWORD);
protocol = props.getOrDefault(ElasticSinkConnector.CONFIG_NAME_ES_PROTOCOL,ElasticSinkConnector.DEFAULT_ES_PROTOCOL);

// Jetty configuration for HTTP client behaviour
proxyHost = props.get(ElasticSinkConnector.CONFIG_NAME_ES_HTTP_PROXY_HOST);
Expand Down