-
Notifications
You must be signed in to change notification settings - Fork 75
feat: support rolldown as an experimental engine #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
XGHeaven
wants to merge
1
commit into
next
Choose a base branch
from
feat/rolldown
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@ice/pkg': minor | ||
--- | ||
|
||
feat: support rolldown as an experimental engine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
import { RolldownOptions, Plugin, OutputOptions } from 'rolldown'; | ||
import { Context, StylesRollupPluginOptions, TaskRunnerContext } from '../../types.js'; | ||
import { getExternalsAndGlobals, getRollupOutputs, PkgJson } from '../rollup/options.js'; | ||
import { assertTaskBundleConfig } from '../../helpers/taskConfig.js'; | ||
import path from 'node:path'; | ||
import getDefaultDefineValues from '../../helpers/getDefaultDefineValues.js'; | ||
import styles from 'rollup-plugin-styler'; | ||
import image from '@rollup/plugin-image'; | ||
import autoprefixer from 'autoprefixer'; | ||
import PostcssPluginRpxToVw from 'postcss-plugin-rpx2vw'; | ||
import { visualizer } from 'rollup-plugin-visualizer'; | ||
import { JSX_RUNTIME_SOURCE } from '../../constants.js'; | ||
import { RollupOptions } from 'rollup'; | ||
|
||
export function getRolldownOptions(context: Context, taskRunnerContext: TaskRunnerContext): RolldownOptions { | ||
const { pkg, commandArgs, command, rootDir } = context; | ||
const { buildTask } = taskRunnerContext; | ||
const { name: taskName, config: taskConfig } = buildTask; | ||
|
||
assertTaskBundleConfig(taskConfig); | ||
|
||
const options: RolldownOptions = {}; | ||
|
||
const [external, globals] = getExternalsAndGlobals(taskConfig, pkg as PkgJson); | ||
|
||
options.input = taskConfig.entry; | ||
options.external = external; | ||
// TODO: should warning if output is multiple | ||
options.output = getRollupOutputs({ | ||
globals, | ||
bundleTaskConfig: taskConfig, | ||
pkg: pkg as PkgJson, | ||
mode: taskRunnerContext.mode, | ||
command, | ||
})[0] as OutputOptions; | ||
|
||
const alias = {}; | ||
Object.keys(taskConfig.alias).forEach((key) => { | ||
// Add full path for relative path alias | ||
alias[key] = taskConfig.alias[key].startsWith('.') | ||
? path.resolve(rootDir, taskConfig.alias[key]) | ||
: taskConfig.alias[key]; | ||
}); | ||
|
||
const plugins: Plugin[] = []; | ||
|
||
options.resolve = { | ||
alias, | ||
}; | ||
options.define = { | ||
...getDefaultDefineValues(taskRunnerContext.mode), | ||
// User define can override above. | ||
...taskConfig.define, | ||
}; | ||
|
||
options.jsx = { | ||
mode: taskConfig.jsxRuntime ?? 'automatic', | ||
jsxImportSource: JSX_RUNTIME_SOURCE, | ||
}; | ||
|
||
const cssMinify = taskConfig.cssMinify(taskRunnerContext.mode, command); | ||
const defaultStylesOptions: StylesRollupPluginOptions = { | ||
plugins: [autoprefixer(), PostcssPluginRpxToVw], | ||
mode: 'extract', | ||
autoModules: true, | ||
minimize: typeof cssMinify === 'boolean' ? cssMinify : cssMinify.options, | ||
sourceMap: taskConfig.sourcemap, | ||
}; | ||
|
||
plugins.push( | ||
styles( | ||
(taskConfig.modifyStylesOptions ?? [(options) => options]).reduce( | ||
(prevStylesOptions, modifyStylesOptions) => modifyStylesOptions(prevStylesOptions), | ||
defaultStylesOptions, | ||
), | ||
) as unknown as Plugin<any>, | ||
image() as unknown as Plugin<any>, | ||
); | ||
|
||
if (commandArgs.analyzer) { | ||
plugins.push( | ||
visualizer({ | ||
title: `Rollup Visualizer(${taskName})`, | ||
open: true, | ||
filename: `${taskName}-stats.html`, | ||
}) as unknown as Plugin<any>, | ||
); | ||
} | ||
|
||
options.plugins = plugins; | ||
|
||
return (taskConfig.modifyRollupOptions ?? [(options) => options]).reduce( | ||
(prevOptions, modifyRollupOptions) => | ||
modifyRollupOptions(prevOptions as unknown as RollupOptions) as RolldownOptions, | ||
options, | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TODO comment indicates incomplete implementation. The
bundle.output
should be properly typed and transformed to match the expectedOutputResult
interface instead of usingany
type assertions.Copilot uses AI. Check for mistakes.