Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/giant-seahorses-call.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ice/pkg': minor
---

feat: support rolldown as an experimental engine
1 change: 1 addition & 0 deletions packages/pkg/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"picocolors": "^1.0.0",
"postcss": "^8.4.31",
"postcss-plugin-rpx2vw": "^1.0.0",
"rolldown": "^0.15.1",
"rollup": "^4.0.0",
"rollup-plugin-styler": "^1.8.0",
"rollup-plugin-visualizer": "^5.12.0",
Expand Down
97 changes: 97 additions & 0 deletions packages/pkg/src/engine/rolldown/options.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
import { RolldownOptions, Plugin, OutputOptions } from 'rolldown';
import { Context, StylesRollupPluginOptions, TaskRunnerContext } from '../../types.js';
import { getExternalsAndGlobals, getRollupOutputs, PkgJson } from '../rollup/options.js';
import { assertTaskBundleConfig } from '../../helpers/taskConfig.js';
import path from 'node:path';
import getDefaultDefineValues from '../../helpers/getDefaultDefineValues.js';
import styles from 'rollup-plugin-styler';
import image from '@rollup/plugin-image';
import autoprefixer from 'autoprefixer';
import PostcssPluginRpxToVw from 'postcss-plugin-rpx2vw';
import { visualizer } from 'rollup-plugin-visualizer';
import { JSX_RUNTIME_SOURCE } from '../../constants.js';
import { RollupOptions } from 'rollup';

export function getRolldownOptions(context: Context, taskRunnerContext: TaskRunnerContext): RolldownOptions {
const { pkg, commandArgs, command, rootDir } = context;
const { buildTask } = taskRunnerContext;
const { name: taskName, config: taskConfig } = buildTask;

assertTaskBundleConfig(taskConfig);

const options: RolldownOptions = {};

const [external, globals] = getExternalsAndGlobals(taskConfig, pkg as PkgJson);

options.input = taskConfig.entry;
options.external = external;
// TODO: should warning if output is multiple
options.output = getRollupOutputs({
globals,
bundleTaskConfig: taskConfig,
pkg: pkg as PkgJson,
mode: taskRunnerContext.mode,
command,
})[0] as OutputOptions;

const alias = {};
Object.keys(taskConfig.alias).forEach((key) => {
// Add full path for relative path alias
alias[key] = taskConfig.alias[key].startsWith('.')
? path.resolve(rootDir, taskConfig.alias[key])
: taskConfig.alias[key];
});

const plugins: Plugin[] = [];

options.resolve = {
alias,
};
options.define = {
...getDefaultDefineValues(taskRunnerContext.mode),
// User define can override above.
...taskConfig.define,
};

options.jsx = {
mode: taskConfig.jsxRuntime ?? 'automatic',
jsxImportSource: JSX_RUNTIME_SOURCE,
};

const cssMinify = taskConfig.cssMinify(taskRunnerContext.mode, command);
const defaultStylesOptions: StylesRollupPluginOptions = {
plugins: [autoprefixer(), PostcssPluginRpxToVw],
mode: 'extract',
autoModules: true,
minimize: typeof cssMinify === 'boolean' ? cssMinify : cssMinify.options,
sourceMap: taskConfig.sourcemap,
};

plugins.push(
styles(
(taskConfig.modifyStylesOptions ?? [(options) => options]).reduce(
(prevStylesOptions, modifyStylesOptions) => modifyStylesOptions(prevStylesOptions),
defaultStylesOptions,
),
) as unknown as Plugin<any>,
image() as unknown as Plugin<any>,
);

if (commandArgs.analyzer) {
plugins.push(
visualizer({
title: `Rollup Visualizer(${taskName})`,
open: true,
filename: `${taskName}-stats.html`,
}) as unknown as Plugin<any>,
);
}

options.plugins = plugins;

return (taskConfig.modifyRollupOptions ?? [(options) => options]).reduce(
(prevOptions, modifyRollupOptions) =>
modifyRollupOptions(prevOptions as unknown as RollupOptions) as RolldownOptions,
options,
);
}
11 changes: 9 additions & 2 deletions packages/pkg/src/engine/rollup/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { getFilenameConfig } from '../shared/filename.js';
import { getTaskSwcOptions } from '../../helpers/defaultSwcConfig.js';
import { assertTaskBuildableConfig } from '../../helpers/taskConfig.js';

interface PkgJson {
export interface PkgJson {
name: string;
version?: string;
dependencies?: Record<string, string>;
Expand Down Expand Up @@ -167,7 +167,14 @@ interface GetRollupOutputsOptions {
mode: NodeEnvMode;
command: Context['command'];
}
function getRollupOutputs({ globals, bundleTaskConfig, pkg, mode, command }: GetRollupOutputsOptions): OutputOptions[] {

export function getRollupOutputs({
globals,
bundleTaskConfig,
pkg,
mode,
command,
}: GetRollupOutputsOptions): OutputOptions[] {
const { outputDir, vendorName = 'vendor' } = bundleTaskConfig;

const outputFormats = bundleTaskConfig.formats ?? [];
Expand Down
6 changes: 6 additions & 0 deletions packages/pkg/src/helpers/taskConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@ export function assertTaskBuildableConfig(
throw new Error('Only accept bundle or transform task.');
}
}

export function assertTaskBundleConfig(taskConfig: TaskConfig): asserts taskConfig is BundleTaskConfig {
if (taskConfig.type !== 'bundle') {
throw new Error('Only accept bundle task.');
}
}
23 changes: 22 additions & 1 deletion packages/pkg/src/tasks/bundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import type { FSWatcher } from 'chokidar';
import type { RslibConfig, Rspack, rsbuild } from '@rslib/core';
import { getRollupOptions } from '../engine/rollup/options.js';
import { Runner } from '../helpers/runner.js';
import { RolldownOptions } from 'rolldown';
import { noop } from 'es-toolkit';
import consola from 'consola';

Expand All @@ -28,6 +29,7 @@ export function createBundleTask(taskRunningContext: TaskRunnerContext) {
export class BundleRunner extends Runner<OutputResult> {
private rollupOptions?: RollupOptions;
private rslibConfig?: RslibConfig;
private rolldownOptions?: RolldownOptions;
private engine: EngineType;
private watcher: Watcher | null = null;
private result: Error | OutputResult | null;
Expand All @@ -43,6 +45,8 @@ export class BundleRunner extends Runner<OutputResult> {
return this.handleRollupBuild(changedFiles);
case 'rslib':
return this.handleRslibBuild(changedFiles);
case 'rolldown':
return this.handleRolldownBuild(changedFiles);
}
}

Expand Down Expand Up @@ -189,6 +193,23 @@ export class BundleRunner extends Runner<OutputResult> {
outputFiles: stats.assets as any,
};
}

private async handleRolldownBuild(changedFiles: WatchChangedFile[]): Promise<OutputResult> {
const { context } = this;
const { build } = await import('rolldown');
if (!this.rolldownOptions) {
const { getRolldownOptions } = await import('../engine/rolldown/options.js');
this.rolldownOptions = getRolldownOptions(context.buildContext, context);
}
const bundle = await build(this.rolldownOptions);

return {
taskName: context.buildTask.name,
// TODO: correct type and value
outputs: bundle.output as any,
outputFiles: bundle.output as any,
Comment on lines +206 to +210
Copy link
Preview

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO comment indicates incomplete implementation. The bundle.output should be properly typed and transformed to match the expected OutputResult interface instead of using any type assertions.

Suggested change
return {
taskName: context.buildTask.name,
// TODO: correct type and value
outputs: bundle.output as any,
outputFiles: bundle.output as any,
// Transform bundle.output to match OutputResult
const outputs = Array.isArray(bundle.output)
? bundle.output.filter((item) => item.type === 'chunk')
: [];
const outputFiles = Array.isArray(bundle.output)
? bundle.output.filter((item) => item.type === 'asset')
: [];
return {
taskName: context.buildTask.name,
outputs,
outputFiles,

Copilot uses AI. Check for mistakes.

};
}
}

// Fork from https://github.com/rollup/rollup/blob/v2.79.1/src/watch/WatchEmitter.ts
Expand Down Expand Up @@ -300,7 +321,7 @@ async function rawBuild(rollupOptions: RollupOptions, taskRunnerContext: TaskRun

const bundle = await rollup.rollup(rollupOptions);

const buildResult = await writeFiles(rollupOutputOptions, bundle.write);
const buildResult = await writeFiles(rollupOutputOptions, bundle.write.bind(bundle));

await bundle.close();

Expand Down
2 changes: 1 addition & 1 deletion packages/pkg/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ interface _TaskConfig {
pkg?: PackageResolvedConfig;
}

export type EngineType = 'rollup' | 'rslib';
export type EngineType = 'rollup' | 'rslib' | 'rolldown';

export interface BundleTaskConfig extends _TaskConfig, Omit<BundleUserConfig, 'development' | 'minify' | 'formats'> {
type: 'bundle';
Expand Down
Loading
Loading