Skip to content

Conversation

ExNDY
Copy link

@ExNDY ExNDY commented Sep 17, 2025

updated:
kotlin 2.2.10
agp 8.12.3
gradle 8.14.3
android min 24
androidTargetSdk 36
zipline 1.23.0

moko-js > 0.4.0

@ExNDY ExNDY requested a review from Alex009 September 17, 2025 07:39
@ExNDY ExNDY self-assigned this Sep 17, 2025
defaultConfig {
minSdkVersion(18)
targetSdkVersion(30)
minSdk = 24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it required?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal new sdk - 21 with actual libs versions, but extentions for versions catalog need 24, i'm can delete extentions and set 21, but not less

jitpack.yml Outdated
Comment on lines 1 to 4
jdk:
- openjdk17
install:
- ./gradlew clean -Pgroup=$GROUP -Pversion=$VERSION -xtest -xlint -xsignMavenPublication publishToMavenLocal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used already

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

Comment on lines 18 to 21
implementation(libs.mokoMultiplatform)
implementation(libs.kotlinGradlePlugin)
implementation(libs.androidGradlePlugin)
implementation(libs.detektPlugin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why implementation instead of api?

Copy link
Author

@ExNDY ExNDY Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback on api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants