#34 Replace MaterialFilePicker dependency and fragmentActivity usage #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiXOps
force-pushed
the
replace-fragment-activity-usage
branch
from
5c0defb to
e86c72a
Compare
added 10 commits
May 2, 2024 11:09
…ediaPickerController method and remove fragmentManager usage at pickImage method
ZiXOps
force-pushed
the
replace-fragment-activity-usage
branch
from
ebbb3d4 to
ccf893d
Compare
Alex009
requested changes
May 6, 2024
Member
Alex009
left a comment
Alex009
left a comment
There was a problem hiding this comment.
required rework to fix large duplication
...mpose/src/androidMain/kotlin/dev/icerock/moko/media/compose/BindMediaPickerEffect.android.kt
Outdated
Show resolved
Hide resolved
media/src/androidMain/kotlin/dev/icerock/moko/media/picker/FilePickerDelegate.kt
Show resolved
Hide resolved
media/src/androidMain/kotlin/dev/icerock/moko/media/picker/ImagePickerDelegate.kt
Show resolved
Hide resolved
Comment on lines
18
to
22
| private var callback: CallbackData? = null | ||
|
|
||
| private val takePictureLauncherHolder = MutableStateFlow<ActivityResultLauncher<Uri>?>(null) | ||
| private val pickVisualMediaLauncherHolder = | ||
| MutableStateFlow<ActivityResultLauncher<PickVisualMediaRequest>?>(null) |
Member
There was a problem hiding this comment.
looks very simillar in multiple places. can we do reused implementation that will use in each case?
media/src/androidMain/kotlin/dev/icerock/moko/media/picker/ImagePickerDelegate.kt
Outdated
Show resolved
Hide resolved
| .commitNow() | ||
| } | ||
| } | ||
| val outputUri = createPhotoUri() |
Member
There was a problem hiding this comment.
why we create it here? in case of gallery we not need it at all
media/src/androidMain/kotlin/dev/icerock/moko/media/picker/MediaPickerDelegate.kt
Show resolved
Hide resolved
| } | ||
|
|
||
| fun onFilePressed() { | ||
| selectFile() |
media/src/androidMain/kotlin/dev/icerock/moko/media/picker/MediaPickerControllerImpl.kt
Show resolved
Hide resolved
Alex009
requested changes
May 14, 2024
| import android.net.Uri | ||
| import dev.icerock.moko.media.BitmapUtils | ||
|
|
||
| internal abstract class ImagePickerDelegate<C, I> : PickerDelegate<C, I>() { |
Member
There was a problem hiding this comment.
we should add here more common logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.